Merge of r4618: rewrite escaping fix (ticket #162).
The following code resulted in incorrect escaping of uri and possible segfault: location / { rewrite ^(.*) $1?c=$1; return 200 "$uri"; } If there were arguments in a rewrite's replacement string, and length was actually calculated (due to duplicate captures as in the example above, or variables present), the is_args flag was set and incorrectly copied after length calculation. This resulted in escaping applied to the uri part of the replacement, resulting in incorrect escaping. Additionally, buffer was allocated without escaping expected, thus this also resulted in buffer overrun and possible segfault.
This commit is contained in:
parent
8340edcb7e
commit
11d364307b
|
@ -1043,7 +1043,6 @@ ngx_http_script_regex_start_code(ngx_http_script_engine_t *e)
|
|||
}
|
||||
|
||||
e->buf.len = len;
|
||||
e->is_args = le.is_args;
|
||||
}
|
||||
|
||||
if (code->add_args && r->args.len) {
|
||||
|
|
Loading…
Reference in New Issue